[Kde-games-devel] KMahjongg archaeology

[Ian Wadham]

Hi Christian,

On 05/01/2015, at 2:29 AM, Christian Krippendorf wrote:
> On Sun, Jan 04, 2015 at 08:22:39PM +1100, Ian Wadham wrote:
>> Hi Alberto, and Christian if you are out there,
>> 
> 
> Yearh i am available. :-)

I am happy to see you are still around… :-)

>> Back in mid-2012 Christian Krippendorf did a lot of work on KMahjongg
>> to port the game from the obsolete and now-deprecated graphics system,
>> KGameCanvas, to the standard Qt graphics system, QGraphicsView.
>> 
>> </snip>
>> I do not know how complete, reviewed and tested Christian's code is,
>> but he certainly put in a lot of work on it.  I succeeded in compiling,
>> building and installing it at first try, even though I have KDE 4.14 libs
>> and the "qgraphic" branch of KMahjongg was originally written for
>> around KDE 4.8 library.
>> 
>> I played a few games with different layouts with no problem and
>> the graphics were certainly a lot snappier than I am getting on the
>> released version of KMahjongg, especially on theme changes,
>> resizes of the main window and animations.  On the whole, Christian's
>> code works very well.  I have a sneaking suspicion that Christian's
>> branch might also have fixed some of the bugs Jan-Peter Nilsson has
>> been working on… :-(
>> 
> 
> There are some bugs in this code. But I don't know anymore what bugs, cause it
> is a long time ago I've been working on it.
> 
>> So now we have divergent streams of work on KMahjongg:
>> 
>>  - A released version of KMahjongg, using obsolete graphics,
>>  - Laurent's port of existing KMahjongg to KF5, using obsolete graphics,
>>  - Christian's port of KMahjongg to QGraphicsView --- branch "qgraphic", unmerged,
>>  - The patch in the above ReviewBoard entry,
>>  - A whole slew of Jan-Peter Nilsson's patches on Bugzilla and ReviewBoard,
>>    some of which may clash with Christian's "qgraphic" branch.
>> 
>> What to do?  I really hate to see good work slipping away.
>> 
> 
> I also told in mid-2012 that I will no longer work on KMahjongg cause of
> starting to study chemistry and having a full-time job. So I don't have the time
> anymore. I also told someone (sry don't know anymore which person) that the port
> is nearly ready. Just few small bugs.
> 
> I also would like to see the code merged into the master branch. But I don't
> know which work has been done after mid-2012 and beside my port.
> 
> Please keep me involved in this process, cause I would like help, if I find a
> little bit of extra time beside my other real-life-things. :-)

Thanks, Christian, let us see what happens…

Cheers, Ian W.