[Kde-games-devel] kMahjongg: Timer keeps running even if game is won

Albert Astals Cid aacid at kde.org
Thu Jan 1 22:01:31 UTC 2015


El Dijous, 1 de gener de 2015, a les 18:27:54, Jan-Peter Nilsson va escriure:
> On 01/01/2015 05:21 PM, Albert Astals Cid wrote:
> ...
> 
> >> Jan-Peter also has also submitted (to kde-games-devel) a reviewbord entry
> >> -
> >> 
> >>     https://git.reviewboard.kde.org/r/121653/.
> > 
> > Yes, i commited them.
> 
> This is a new one, I uploaded it about a week ago.
> 
> >> And yes, he also wrote a patch for
> >> https://bugs.kde.org/show_bug.cgi?id=199844 (Timer keeps running even if
> >> game is won)
> > 
> > Jan-Peter, don't use bugzilla for patches if you want me to have a look at
> > them (i'm not the maintainer of KMahjongg, but if noone does, i dedicate
> > some random time to review patches)
> 
> My plan have been to upload them to review board, but it does not let me
> upload patches based on something that is not already merged.
> So in the meanwhile I have added some patches to bugzilla to make them
> available/visible to others.
> 
> How do you prefer to get patches?

As i said, reviewboard :D

it's the only way *I* will see them, if someone else looks at them in bugzilla 
i do not know

Cheers,
  Albert

> 
> //Jan-Peter
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel



More information about the kde-games-devel mailing list