[Kde-games-devel] Review Request 121589: Rename binary to ksnakeduel

[Albert Astals Cid]

> On feb. 19, 2015, 2:18 p.m., Michał Zając wrote:
> > Ship It!

This is a bit borderline, next time you give a Ship it! to stuff you're never contributed to i'd appreciate that you make it clear you're not a contributor to such project and just agreeing.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121589/#review76296
-----------------------------------------------------------


On feb. 19, 2015, 2:22 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121589/
> -----------------------------------------------------------
> 
> (Updated feb. 19, 2015, 2:22 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksnakeduel
> 
> 
> Description
> -------
> 
> For some reason ksnakeduel has three names. This gets rid of one of them, ktron and changes it to ksnakeduel. This was mostly done already but this changes the binary name too which was causing confusion to us little packagers.
> 
> I also think the kdesnake script and .desktop file should go away, you can set it in the UI.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 49616d7 
>   pics/hi32-app-kdesnake.png 27b133b 
>   pics/hi32-app-ksnakeduel.png PRE-CREATION 
>   pics/hi32-app-ktron.png f467683 
>   pics/hi48-app-kdesnake.png 556c9e1 
>   pics/hi48-app-ksnakeduel.png PRE-CREATION 
>   pics/hi48-app-ktron.png ac857f9 
>   pics/hi64-app-kdesnake.png e9d7ebe 
>   pics/hi64-app-ksnakeduel.png PRE-CREATION 
>   pics/hi64-app-ktron.png a79a401 
>   settings.kcfgc 8450b7d 
>   themes/CMakeLists.txt aad7fed 
>   doc/CMakeLists.txt 99fed14 
>   kdesnake.cmake 0a4e46d 
>   kdesnake.desktop 5e49105 
>   ksnakeduel.desktop PRE-CREATION 
>   ksnakeduel.kcfg PRE-CREATION 
>   ksnakeduel.knsrc PRE-CREATION 
>   ksnakeduelui.rc PRE-CREATION 
>   ktron.desktop 3b2e386 
>   ktron.kcfg ab764b9 
>   ktron.knsrc 9cc0835 
>   ktronui.rc baab667 
>   main.cpp 79fb05f 
>   pics/hi128-app-kdesnake.png 797a458 
>   pics/hi128-app-ksnakeduel.png PRE-CREATION 
>   pics/hi128-app-ktron.png 73da488 
>   pics/hi16-app-kdesnake.png de8f38a 
>   pics/hi16-app-ksnakeduel.png PRE-CREATION 
>   pics/hi16-app-ktron.png 0928dbf 
>   pics/hi22-app-kdesnake.png 1b7948b 
>   pics/hi22-app-ksnakeduel.png PRE-CREATION 
>   pics/hi22-app-ktron.png e2206df 
>   pics/hi256-app-kdesnake.png 270a652 
>   pics/hi256-app-ksnakeduel.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121589/diff/
> 
> 
> Testing
> -------
> 
> compile, install and run
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150219/feaad1e7/attachment-0001.html>