[Kde-games-devel] Freeze in 6 weeks

[laurent Montel]

Le Tuesday 17 February 2015 22:31:05 Mathias Kraus a écrit :
> Am Dienstag, 17. Februar 2015, 00:21:01 schrieb Albert Astals Cid:
> > El Divendres, 13 de febrer de 2015, a les 07:21:10, laurent Montel va 
escriure:
> > > Le Thursday 12 February 2015 23:36:19 Albert Astals Cid a écrit :
> > > > El Dimecres, 11 de febrer de 2015, a les 07:48:03, laurent Montel va
> > > > 
> > > > > - granatier (I hope to remove all kdelibs4support) and merge it.
> > > > 
> > > > It's crashing for me at the moment
> > > 
> > > Ah ?
> > > I need more info for it as I can't reproduce.
> > > 
> > > Perhaps it tries to load an invalid theme no ?
> > 
> > diff --git a/src/gamescene.cpp b/src/gamescene.cpp
> > index fb574f3..47bfd0b 100644
> > --- a/src/gamescene.cpp
> > +++ b/src/gamescene.cpp
> > @@ -70,7 +70,7 @@ GameScene::GameScene(Game* p_game, KgThemeProvider*
> > p_themeProvider) : m_game(p_> 
> >      {
> >      
> >          const QString desktopPath = players[i]->getDesktopFilePath();
> >          KgTheme* theme = new KgTheme(desktopPath.toUtf8());
> > 
> > -       
> > theme->readFromDesktopFile(QStandardPaths::locate(QStandardPaths::DataLoc
> > ation, desktopPath)); +        theme->readFromDesktopFile(desktopPath);
> > 
> >          KGameRenderer* playerRenderer = new KGameRenderer(theme);
> >          m_mapRendererPlayerItems.insert(players[i], playerRenderer);
> >          playerItem = new PlayerItem(players[i], playerRenderer);
> > 
> > This fixes the crash for me.
> 
> Yes, this is the right fix. Please commit.
> 

Indeed it fixes the crash that I was able to reproduce now.
But I don't understand why porting was bad here.
Perhaps because all is not port to kf5 yet.