[Kde-games-devel] Freeze in 6 weeks

[Albert Astals Cid]

El Divendres, 13 de febrer de 2015, a les 07:21:10, laurent Montel va escriure:
> Le Thursday 12 February 2015 23:36:19 Albert Astals Cid a écrit :
> > El Dimecres, 11 de febrer de 2015, a les 07:48:03, laurent Montel va
> 
> escriure:
> > > Le Sunday 08 February 2015 08:01:51 laurent Montel a écrit :
> > > > > Tried them both, look fine here.
> > > > 
> > > > Merged in master.
> > > > Next games: kbounce/kblackbox.
> > > 
> > > I merged them.
> > > (I added a note about kbounce in my todo to continue to investigate
> > > about
> > > speed, but I need a kdegames dev for it I think).
> > > 
> > > Now I would like to merge:
> > > - kbreakout
> > > - knetwalk
> > 
> > knetwalk says
> > 
> > Shortcut for action  "kb_go_right" "Keyboard: Field right" set with
> > QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s)
> > instead. Shortcut for action  "kb_go_left" "Keyboard: Field left" set with
> > QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s)
> > instead. Shortcut for action  "kb_go_up" "Keyboard: Field up" set with
> > QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s)
> > instead. Shortcut for action  "kb_go_down" "Keyboard: Field down" set with
> > QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s)
> > instead. Shortcut for action  "kb_turn_clockwise" "Keyboard: Turn
> > clockwise" set with QAction::setShortcut()! Use
> > KActionCollection::setDefaultShortcut(s) instead. Shortcut for action
> > "kb_turn_counterclockwise" "Keyboard: Turn
> > counterclockwise" set with QAction::setShortcut()! Use
> > KActionCollection::setDefaultShortcut(s) instead.
> > Shortcut for action  "kb_lock" "Keyboard: Toggle lock" set with
> > QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s)
> > instead.
> 
> Fixed.
> 
> > > - granatier (I hope to remove all kdelibs4support) and merge it.
> > 
> > It's crashing for me at the moment
> 
> Ah ?
> I need more info for it as I can't reproduce.
> 
> Perhaps it tries to load an invalid theme no ?


diff --git a/src/gamescene.cpp b/src/gamescene.cpp
index fb574f3..47bfd0b 100644
--- a/src/gamescene.cpp
+++ b/src/gamescene.cpp
@@ -70,7 +70,7 @@ GameScene::GameScene(Game* p_game, KgThemeProvider* p_themeProvider) : m_game(p_
     {
         const QString desktopPath = players[i]->getDesktopFilePath();
         KgTheme* theme = new KgTheme(desktopPath.toUtf8());
-        theme->readFromDesktopFile(QStandardPaths::locate(QStandardPaths::DataLocation, desktopPath));
+        theme->readFromDesktopFile(desktopPath);
         KGameRenderer* playerRenderer = new KGameRenderer(theme);
         m_mapRendererPlayerItems.insert(players[i], playerRenderer);
         playerItem = new PlayerItem(players[i], playerRenderer);

This fixes the crash for me.

Does it still work for you with it?

Cheers,
  Albert

> 
> > ==14878== Invalid read of size 8
> > ==14878==    at 0x5BD146A: KgTheme::name() const (in
> > /home/kdeunstable/instalado/lib/x86_64-linux-gnu/libKF5KDEGames.so.6.1.0)
> > ==14878==    by 0x5BC551E: KGameRendererPrivate::_k_setTheme(KgTheme
> > const*) (in
> > /home/kdeunstable/instalado/lib/x86_64-linux-gnu/libKF5KDEGames.so.6.1.0)
> > ==14878==    by 0x5BC600E: KGameRenderer::frameCount(QString const&) const
> > (in
> > /home/kdeunstable/instalado/lib/x86_64-linux-gnu/libKF5KDEGames.so.6.1.0)
> > ==14878==    by 0x5BC67B4: KGameRenderer::spriteExists(QString const&)
> > const (in
> > /home/kdeunstable/instalado/lib/x86_64-linux-gnu/libKF5KDEGames.so.6.1.0)
> > ==14878==    by 0x49010D: PlayerItem::PlayerItem(Player*, KGameRenderer*)
> > (in /home/kdeunstable/instalado/bin/granatier)
> > ==14878==    by 0x46F147: GameScene::GameScene(Game*, KgThemeProvider*)
> > (in
> > /home/kdeunstable/instalado/bin/granatier)
> > ==14878==    by 0x486F93: MainWindow::initGame() (in
> > /home/kdeunstable/instalado/bin/granatier)
> > ==14878==    by 0x4869BF: MainWindow::MainWindow() (in
> > /home/kdeunstable/instalado/bin/granatier)
> > ==14878==    by 0x485FBF: main (in
> > /home/kdeunstable/instalado/bin/granatier)
> > 
> > Cheers,
> > 
> >   Albert
> >   
> > > The freeze is the 25 so others games are not kdelibs4 free I need to
> > > focus
> > > some some applications. Do you have a some specific apps that you want
> > > that
> > > we release with 15.04 ?
> > > 
> > > Regards
> > > _______________________________________________
> > > kde-games-devel mailing list
> > > kde-games-devel at kde.org
> > > https://mail.kde.org/mailman/listinfo/kde-games-devel