[Kde-games-devel] Review Request 122582: [knetwalk] Make tests optional

[Andreas Sturmlechner]

> On Feb. 16, 2015, 3:14 p.m., Laurent Montel wrote:
> > Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted
> > ********* Finished testing of AbstractGridTest *********
> > 
> > For me it doesn't fail here.
> 
> Andreas Sturmlechner wrote:
>     You're right, they work when I build knetwalk as user.

OK, xhost was actually missing from that particular test box - sorry for the noise wrt failing tests. ;)


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122582/#review76133
-----------------------------------------------------------


On Feb. 15, 2015, 9:54 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122582/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2015, 9:54 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: knetwalk
> 
> 
> Description
> -------
> 
> [knetwalk] Make tests optional
> 
> Qt5Test dependency should not be mandatory, this patch makes it optional following the example set by kwin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 49f86d6df721d56d372cdb4947f48d6cde1ee54f 
> 
> Diff: https://git.reviewboard.kde.org/r/122582/diff/
> 
> 
> Testing
> -------
> 
> Built with and without tests. Currently tests fail though, before and after patch.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150216/228b3f96/attachment.html>