[Kde-games-devel] Review Request 120192: FIx for issue 337826 where the status bar would not update to reflect the player name until a game was initiated. Also changed the default name for the left player to "KSnakeDuel".

[Stephen Michalski]

On 02/09/2015 05:49 PM, Albert Astals Cid wrote:
> This is an automatically generated e-mail. To reply, visit: 
> https://git.reviewboard.kde.org/r/120192/
>
>
>     On desembre 14th, 2014, 6:43 p.m. UTC, *Albert Astals Cid* wrote:
>
>         This still seems to not totally work for me.
>
>
>         This is what i did: rm ~/.kde/share/config/ktronrc (or .kde4
>         if your settings are there) start ktron
>
>
>         And the welcome screen says "KSnakeDuel (0 points) versus (0
>         points)" (i.e. the name seems to be empty)
>
>
>         And if i go to settings -> Configure, Right Player is empty
>         and left is "Player 2".
>
>
>         Can you reproduce this?
>
> Ping?
>
I apologize for the delay.

I am able to reproduce this behaviour.
>
> - Albert
>
>
> On octubre 14th, 2014, 3:13 p.m. UTC, Stephen Michalski wrote:
>
> Review request for KDE Games and Albert Astals Cid.
> By Stephen Michalski.
>
> /Updated oct. 14, 2014, 3:13 p.m./
>
> *Bugs: * 337826 <http://bugs.kde.org/show_bug.cgi?id=337826>
> *Repository: * ksnakeduel
>
>
>   Description
>
> Fix for bug 337826
>
>
>   Testing
>
> Game was run for 5 rounds in player vs. player mode and then switched 
> to player vs. computer mode, which was then played for 5 rounds.
>
>
>   Diffs
>
>   * ktron.cpp (4082ff6)
>   * ktron.kcfg (ab764b9)
>
> View Diff <https://git.reviewboard.kde.org/r/120192/diff/>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150209/af9371c8/attachment.html>