[Kde-games-devel] Review Request 122436: Make Renderer be owned by the MainWindow instead of being a static

Jeremy Whiting jpwhiting at kde.org
Thu Feb 5 02:22:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122436/#review75446
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Whiting


On Feb. 4, 2015, 5:46 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122436/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 5:46 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kdiamond
> 
> 
> Description
> -------
> 
> There's no need for it to be static and making it non static fixes saving the current theme on exit
> 
> 
> Diffs
> -----
> 
>   src/board.h 7240afb 
>   src/board.cpp 3ac5ccd 
>   src/game.h 5ca71b3 
>   src/game.cpp f83d378 
>   src/mainwindow.h d226235 
>   src/mainwindow.cpp fc54c3e 
> 
> Diff: https://git.reviewboard.kde.org/r/122436/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150205/402a601a/attachment.html>


More information about the kde-games-devel mailing list