[Kde-games-devel] Review Request 126124: Port to KF5/QT5

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126124/#review89743
-----------------------------------------------------------



src/board.h (lines 30 - 33)
<https://git.reviewboard.kde.org/r/126124/#comment61489>

    Here you removed the QtGui/ module path but left the QtCore/ one. Is there a reason for that?



src/board.cpp (line 37)
<https://git.reviewboard.kde.org/r/126124/#comment61490>

    The own header files schould come first.
    
    Also maybe avoid mixing QheaderFile with qheaderfile.h styles.



src/board.cpp (line 109)
<https://git.reviewboard.kde.org/r/126124/#comment61491>

    Just a hint: Have a look at other hdegames, like KShisen. They use qCDebug(), which can help you see where debug output is coming from.
    
    See src/kshisen_debug.* and then how it is used like
    qCDebug(KSHISEN_LOG) << "Time: " << m_board->currentTime();



src/clockwidget.cpp (line 26)
<https://git.reviewboard.kde.org/r/126124/#comment61492>

    Own headers first, again.


- Frederik Schwarzer


On Dec. 16, 2015, 8:09 p.m., Manoharan Sundaramoorthy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126124/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 8:09 p.m.)
> 
> 
> Review request for KDE Games, Knights and Miha Čančula.
> 
> 
> Repository: knights
> 
> 
> Description
> -------
> 
> Knights: Port to KF5/QT5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ed25a68 
>   doc/CMakeLists.txt 5aad7c2 
>   icons/16-apps-knights.png PRE-CREATION 
>   icons/32-apps-knights.png PRE-CREATION 
>   icons/48-apps-knights.png PRE-CREATION 
>   icons/64-apps-knights.png PRE-CREATION 
>   icons/CMakeLists.txt 7affd27 
>   icons/hi16-app-knights.png ee4a3d9 
>   icons/hi32-app-knights.png 120c7b2 
>   icons/hi48-app-knights.png 26684f0 
>   icons/hi64-app-knights.png df75196 
>   src/CMakeLists.txt 6d77801 
>   src/board.h d464bd1 
>   src/board.cpp 775cfd8 
>   src/clock.h 340c885 
>   src/clockwidget.h 5686a95 
>   src/clockwidget.cpp 2a4e744 
>   src/core/item.cpp 30fe74e 
>   src/core/move.h 50e32b0 
>   src/core/move.cpp 4f7ca0e 
>   src/core/piece.cpp 4564ae8 
>   src/customdifficultydialog.ui f9f7b29 
>   src/enginesettings.h 2942ad1 
>   src/enginesettings.cpp 4802ce0 
>   src/enginesettings.ui eb59af2 
>   src/externalcontrol.h 40dbf55 
>   src/externalcontrol.cpp 1467491 
>   src/gamedialog.h 5518290 
>   src/gamedialog.cpp 2d0a124 
>   src/gamedialog.ui 436887d 
>   src/gamemanager.h fe7f883 
>   src/gamemanager.cpp c9d9566 
>   src/historywidget.cpp 9f7f3fd 
>   src/historywidget.ui aacc0be 
>   src/knights.cpp cb688a7 
>   src/knights.desktop 400cf57 
>   src/knightsview.h 40df529 
>   src/knightsview.cpp 5451eb9 
>   src/main.cpp 504fcc5 
>   src/offerwidget.cpp 0993ae2 
>   src/org.kde.knights.desktop PRE-CREATION 
>   src/popup.ui d4665af 
>   src/promotiondialog.ui 810e67d 
>   src/proto/chatwidget.h 4afcdf6 
>   src/proto/chatwidget.cpp fa209f9 
>   src/proto/chatwidget.ui 82ff8b7 
>   src/proto/computerprotocol.cpp a0b032f 
>   src/proto/ficsdialog.h 93d5564 
>   src/proto/ficsdialog.cpp d89a07c 
>   src/proto/ficsdialog.ui 8eea2e7 
>   src/proto/ficsprotocol.h 3d3e395 
>   src/proto/ficsprotocol.cpp 2c9b07d 
>   src/proto/localprotocol.cpp 711ec5c 
>   src/proto/protocol.cpp e489d33 
>   src/proto/seekgraph.h cba3b5f 
>   src/proto/seekgraph.cpp 3c83591 
>   src/proto/textprotocol.h 8216f24 
>   src/proto/textprotocol.cpp d6f5290 
>   src/proto/uciprotocol.cpp 69d7efb 
>   src/proto/xboardprotocol.cpp 01fb4ae 
>   src/rules/chessrules.cpp 3e993e4 
>   src/rules/rules.h 032cde4 
> 
> Diff: https://git.reviewboard.kde.org/r/126124/diff/
> 
> 
> Testing
> -------
> 
> 1. Tested Playing against gnuchess
> 2. Two human players
> 3. Playing with clock
> 
> 
> Thanks,
> 
> Manoharan Sundaramoorthy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151219/a890b799/attachment-0001.html>