[Kde-games-devel] Review Request 126383: Use of QScopedPointer for avoiding crashy dialogs.

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126383/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 9:56 a.m.)


Review request for KDE Games.


Changes
-------

Check for pointer's validity.


Repository: libkdegames


Description
-------

I recently found out about QScopedPointer and thought it might be a good thing to use instead of QPointer in many cases.
So I tested it with two crashy dialogs in libkdegames.
Please comment in case I forgot to think about something.


Diffs (updated)
-----

  kgthemeselector.cpp 9cd9c61 
  libkdegamesprivate/kgamethemeselector.cpp ce3cf1f 

Diff: https://git.reviewboard.kde.org/r/126383/diff/


Testing
-------

Used the KNS3 dialog in Kigo.


Thanks,

Frederik Schwarzer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151217/74375e48/attachment.html>