[Kde-games-devel] KMahjongg frameworks branch

[Frederik Schwarzer]

Am Freitag, 11. Dezember 2015, 14:10:11 schrieb Ian Wadham:
> On 10/12/2015, at 8:02 PM, Frederik Schwarzer wrote:

Hi Ian,

> Not sure what you mean by "enter group".  Is it a menu item?  Is it
> a keyboard shortcut?  Is it a Select option?  I have Inkscape 0.91
> and all it seems to have is menu items Object->Group and
> Object->Ungroup regarding groups.

I have an additional context menu entry sometimes (have not figured out 
why it is not always there) names "Enter Group". Version is 0.91 as 
well. You can work on parts of a group without ungroup->...->group.

> Looking at the XML of the Classic theme, it looks as though all 8
> blank tiles in the group just above the tile-face pictures are
> supposed to be derived from the two blank tiles at the top of the
> SVG layout.  It also looks as though some of the links have been
> broken, especially in TILE_1 (which has its shadow at the
> south-west corner).

Yes, TILE_1 was the one I was playing around with because its shadow 
did not change when I changed the shadow of one of the tiles at the 
top.

> I also tried menu item Edit->Clone->Show Original (shortcut Shift D)
> on the group of 8.  Some of them are clones of the top 2. but most
> are not.  I think they are all supposed to be, but have been broken
> at some stage.  There is an unfinished theme in libkmahjongg called
> Bamboo.  It is inspired by the Classic theme and seems to work
> roughly that way with its blank tiles and clones.  Using Shift D on
> Bamboo's group of 8 shows that they are in 2 groups of 4.  Each
> group of 4 has 3 tiles that are clones of the 4th tile.
> 
> A clone can be transformed from the original but retain its colour
> and shape, so my theory is that, in the Classic theme's SVG layout,
> the unshadowed tile all by itself at the left is originally the
> "grandfather" of the 8 tiles and the "father" of the 2 tiles at the
> top, which have had shadows and highlighting added.

That's what I suspect as well. But so far I cannot see that in the file 
itself. Maybe we need DNA tests. :)

> To create a clone, use Edit->Clone->Create Clone, move it to where
> you want it (it starts on top of the original), then use
> Object->Flip Horizontal (key H) and/or Object->Flip Vertical (key
> V) to get the shadows where you want them.

Just did that (the cloning hint was very helpful) and now Ahift+D 
shows the correct original.

> I tried renaming TILE_1 to WAS_TILE_1, then creating a clone and
> calling it TILE_1 and flipping the shadows to the south-west. 
> Guess what?  The new TILE_1 stayed in good alignment with the
> tile-faces and with its highlighted counterpart.

That's great news. Here it now works as well. Do you want to commit 
your changes? You have more insight into this. I mean, my version 
works as well, but I still do not see through this. There must be some 
other kind of linkage between the tiles than cloning. The unselected 
tile at the top (XML: id="g3381") is using the tile on the outer left 
(XML: <use xlink:href="#Tile" [...]). ... Ok, now I removed the outer 
left tile and everything still works. Maybe it was just there during 
creation of the tiles? ... ... ... OK, now I removed all tiles except 
the upper two, ungrouped them (several layers of grouping), named 
everything (what's #g3372 anyway?), regrouped them and cloned the 8 
final tiles from it. I attached the file. Please review and comment. 


> Mind you, I do not think that changing the opacity of the whole tile
> is the way to go.  It lets the background and the tiles underneath
> show through.  There must be some way to change just the shadows…
> ;-)

Yep. I only changed the shadow by "entering" the group. Apparently 
cloned cannot be ungrouped so it only worked on TILE_1.

Regards,
Frederik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: classic.svg.zip
Type: application/zip
Size: 129003 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151211/c2588c41/attachment-0001.zip>