[Kde-games-devel] Review Request 123328: Some fixes for OSX
Marko Käning
mk-lists at email.de
Sat Apr 11 13:00:16 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123328/
-----------------------------------------------------------
(Updated April 11, 2015, 3 p.m.)
Review request for KDE Games, Ian Wadham and Minh Ngo.
Changes
-------
use consistent syntax in checks for Q_OS_MAC
Repository: kdots
Description
-------
Hi Minh,
I've added a RB config as well as introduced some changes re std:abs() specific to OSX. Also I added a forgotten include.
There's another issue to be fixed, but I'll post this to the mailing list independently.
Greets,
Marko
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
CMakeLists.txt 81b1273bee0f5c930ec350edfd2030150b053ee1
kdotslib/constants.hpp d983ae240aad354e8db33e34c72fa3d41f8ef029
kdotslib/polygon.hpp dca4b55594372be7db96e92f11dc8af39052ce1e
kdotslib/polygon.cpp ace662d08b4984dc87744acebebe7f7c26172a97
kdotslib/stepqueue.hpp 2ff853e558e69ba31122245b1bdb5cd240e45afb
main.cpp adfaab93821033d036615b73ad7eba351b19b715
pictures/CMakeLists.txt 90cebc068fe4a85b8370368fbebc8ec597412af7
Diff: https://git.reviewboard.kde.org/r/123328/diff/
Testing
-------
Builds now also on OSX.
Thanks,
Marko Käning
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150411/172a34e7/attachment.html>
More information about the kde-games-devel
mailing list