[Kde-games-devel] Review Request 123328: Some fixes for OSX

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123328/
-----------------------------------------------------------

(Updated April 11, 2015, 12:51 p.m.)


Review request for KDE Games, Ian Wadham and Minh Ngo.


Changes
-------

Fixed the install location for the rc file.

The application package gets built now,
but 
 * the app icon doesn't appear on startup in the OSX dock (other games have no problem there)
 * the game's main dialog stays empty

When I opened the "Preferences" dialog I got this:
```
QWidget::setProperty: Property "modal" invalid, read-only or does not exist
```

On starting a new game on the console I got:
```
Plugins not found in  "/opt/kde/install/darwin/mavericks/clang/kf5-qt5/kdereview/kdots/inst/lib/plugins/kdots"
```
although the so's are there:
```
$ ls /opt/kde/install/darwin/mavericks/clang/kf5-qt5/kdereview/kdots/inst/lib/plugins/kdots
kdots_ipconnect.so  kdots_simpleai.so  kdots_singlepc.so  rules
```


Repository: kdots


Description
-------

Hi Minh,

I've added a RB config as well as introduced some changes re std:abs() specific to OSX. Also I added a forgotten include.

There's another issue to be fixed, but I'll post this to the mailing list independently.

Greets,
Marko


Diffs (updated)
-----

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt 81b1273bee0f5c930ec350edfd2030150b053ee1 
  kdotslib/polygon.hpp dca4b55594372be7db96e92f11dc8af39052ce1e 
  kdotslib/polygon.cpp ace662d08b4984dc87744acebebe7f7c26172a97 
  kdotslib/stepqueue.hpp 2ff853e558e69ba31122245b1bdb5cd240e45afb 
  pictures/CMakeLists.txt 90cebc068fe4a85b8370368fbebc8ec597412af7 

Diff: https://git.reviewboard.kde.org/r/123328/diff/


Testing
-------

Builds now also on OSX.


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150411/ce793620/attachment.html>