[Kde-games-devel] Review Request 123328: Some fixes for OSX

[Marko Käning]

> On April 11, 2015, 10:51 a.m., Marko Käning wrote:
> > The executable gets installed in
> > ```
> > /kdereview/kdots/inst/bin/kdots
> > ```
> > i.e. not as an application package.
> > 
> > Is CMake missing some OSX'ish magic there?
> 
> Minh Ngo wrote:
>     Possibly ${BIN_INSTALL_DIR} in CMakeLists.txt should be replaced as ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}.

We were crossing lines with my subsequent update to this RR. :)

Unfortunately that is not yet enough.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123328/#review78785
-----------------------------------------------------------


On April 11, 2015, 11:12 a.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123328/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 11:12 a.m.)
> 
> 
> Review request for KDE Games and Minh Ngo.
> 
> 
> Repository: kdots
> 
> 
> Description
> -------
> 
> Hi Minh,
> 
> I've added a RB config as well as introduced some changes re std:abs() specific to OSX. Also I added a forgotten include.
> 
> There's another issue to be fixed, but I'll post this to the mailing list independently.
> 
> Greets,
> Marko
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   CMakeLists.txt 81b1273bee0f5c930ec350edfd2030150b053ee1 
>   kdotslib/polygon.hpp dca4b55594372be7db96e92f11dc8af39052ce1e 
>   kdotslib/polygon.cpp ace662d08b4984dc87744acebebe7f7c26172a97 
>   kdotslib/stepqueue.hpp 2ff853e558e69ba31122245b1bdb5cd240e45afb 
> 
> Diff: https://git.reviewboard.kde.org/r/123328/diff/
> 
> 
> Testing
> -------
> 
> Builds now also on OSX.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150411/68111dd0/attachment-0001.html>