[Kde-games-devel] Review Request 123328: Some fixes for OSX
Marko Käning
mk-lists at email.de
Sat Apr 11 08:51:59 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123328/#review78785
-----------------------------------------------------------
The executable gets installed in
```
/kdereview/kdots/inst/bin/kdots
```
i.e. not as an application package.
Is CMake missing some OSX'ish magic there?
- Marko Käning
On April 11, 2015, 10:40 a.m., Marko Käning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123328/
> -----------------------------------------------------------
>
> (Updated April 11, 2015, 10:40 a.m.)
>
>
> Review request for KDE Games and Minh Ngo.
>
>
> Repository: kdots
>
>
> Description
> -------
>
> Hi Minh,
>
> I've added a RB config as well as introduced some changes re std:abs() specific to OSX. Also I added a forgotten include.
>
> There's another issue to be fixed, but I'll post this to the mailing list independently.
>
> Greets,
> Marko
>
>
> Diffs
> -----
>
> kdotslib/stepqueue.hpp 2ff853e558e69ba31122245b1bdb5cd240e45afb
> kdotslib/polygon.cpp ace662d08b4984dc87744acebebe7f7c26172a97
> .reviewboardrc PRE-CREATION
> kdotslib/polygon.hpp dca4b55594372be7db96e92f11dc8af39052ce1e
>
> Diff: https://git.reviewboard.kde.org/r/123328/diff/
>
>
> Testing
> -------
>
> Builds now also on OSX.
>
>
> Thanks,
>
> Marko Käning
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150411/032b3be1/attachment.html>
More information about the kde-games-devel
mailing list