[Kde-games-devel] Review Request 123328: Some fixes for OSX

Marko Käning mk-lists at email.de
Sat Apr 11 08:39:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123328/
-----------------------------------------------------------

(Updated April 11, 2015, 10:39 a.m.)


Review request for KDE Games, Ian Wadham and Minh Ngo.


Changes
-------

set branch


Repository: kdots


Description
-------

Hi Minh,

I've added a RB config as well as introduced some changes re std:abs() specific to OSX. Also I added a forgotten include.

There's another issue to be fixed, but I'll post this to the mailing list independently.

Greets,
Marko


Diffs
-----

  .reviewboardrc PRE-CREATION 
  kdotslib/polygon.cpp ace662d08b4984dc87744acebebe7f7c26172a97 
  kdotslib/stepqueue.hpp 2ff853e558e69ba31122245b1bdb5cd240e45afb 

Diff: https://git.reviewboard.kde.org/r/123328/diff/


Testing
-------

Builds now on OSX up to 
```
kdotslib/polygonfinder.cpp:63:18: error: no matching member function for call to 'push_back'
```


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150411/8821e676/attachment.html>


More information about the kde-games-devel mailing list