[Kde-games-devel] Review Request 120192: FIx for issue 337826 where the status bar would not update to reflect the player name until a game was initiated. Also changed the default name for the left player to "KSnakeDuel".

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120192/#review67587
-----------------------------------------------------------


The problem with this patch is if you
   rm ~/.kde/share/config/ktronrc 
run ktron and go into settings, the player 2 name is empty.

Maybe you can try editing ktron.kcfg to have the code that defaults there like the one in kiriki.kcfg ? http://quickgit.kde.org/?p=kiriki.git&a=blob&h=d9ee44935f7599b2c3ad4231bb5d3817c0415ef3&hb=e142d10f273575eaeb2aa8543fde92bd7f929a7f&f=src%2Fkiriki.kcfg

- Albert Astals Cid


On set. 19, 2014, 1:31 p.m., Stephen Michalski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120192/
> -----------------------------------------------------------
> 
> (Updated set. 19, 2014, 1:31 p.m.)
> 
> 
> Review request for KDE Games and Albert Astals Cid.
> 
> 
> Bugs: 337826
>     http://bugs.kde.org/show_bug.cgi?id=337826
> 
> 
> Repository: ksnakeduel
> 
> 
> Description
> -------
> 
> Fix for bug 337826
> 
> 
> Diffs
> -----
> 
>   ktron.cpp 4082ff6 
> 
> Diff: https://git.reviewboard.kde.org/r/120192/diff/
> 
> 
> Testing
> -------
> 
> Game was run for 5 rounds in player vs. player mode and then switched to player vs. computer mode, which was then played for 5 rounds. 
> 
> 
> Thanks,
> 
> Stephen Michalski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140928/0c828200/attachment.html>