[Kde-games-devel] Review Request 120288: Initial port of libkmahjongg to Frameworks

[Raymond Wooninck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120288/
-----------------------------------------------------------

(Updated Sept. 19, 2014, 8:42 p.m.)


Review request for KDE Games, Albert Astals Cid and Hrvoje Senjan.


Changes
-------

Some small changes in the cmake build structure that were discussed on IRC with Hrvoje. 


Summary (updated)
-----------------

Initial port of libkmahjongg to Frameworks


Repository: libkmahjongg


Description
-------

Initial port to Frameworks. This would mean that a new branch Frameworks is created for this library where we can work further on it


Diffs (updated)
-----

  CMakeLists.txt 8db109d 
  KF5KMahjongglibConfig.cmake.in PRE-CREATION 
  kmahjonggbackground.cpp c63968f 
  kmahjonggbackgroundselector.cpp 1ed407f 
  kmahjonggconfigdialog.h ed27f41 
  kmahjonggconfigdialog.cpp c90fefd 
  kmahjonggtileset.cpp 938e292 
  kmahjonggtilesetselector.cpp 6e32867 

Diff: https://git.reviewboard.kde.org/r/120288/diff/


Testing
-------

Library compiles without deprecated warnings and errors. Functionality can only be tested once kmahjongg itself is ported (which would be the next step)


Thanks,

Raymond Wooninck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140919/ddec340e/attachment.html>