[Kde-games-devel] Review Request 120192: FIx for issue 337826 where the status bar would not update to reflect the player name until a game was initiated. Also changed the default name for the left player to "KSnakeDuel".

[Stephen Michalski]

> On Sept. 18, 2014, 9:37 p.m., Albert Astals Cid wrote:
> > player.cpp, line 116
> > <https://git.reviewboard.kde.org/r/120192/diff/1/?file=312098#file312098line116>
> >
> >     I don't think this change makes sense, why forcing to KSnakeduel? Maybe it should be KSnakeduel for player vs computer, but player vs player?

I interpreted from the bug that I viewed at the [KDE Bugtracking System](https://bugs.kde.org/show_bug.cgi?id=337826) that the default name was to be KSnakeDuel. What you're stating is more sensible and I've updated the diff to only re-order to function calls to the Tron and KTron implementations of loadSettings().


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120192/#review66882
-----------------------------------------------------------


On Sept. 19, 2014, 1:31 p.m., Stephen Michalski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120192/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 1:31 p.m.)
> 
> 
> Review request for KDE Games and Albert Astals Cid.
> 
> 
> Bugs: 337826
>     http://bugs.kde.org/show_bug.cgi?id=337826
> 
> 
> Repository: ksnakeduel
> 
> 
> Description
> -------
> 
> Fix for bug 337826
> 
> 
> Diffs
> -----
> 
>   ktron.cpp 4082ff6 
> 
> Diff: https://git.reviewboard.kde.org/r/120192/diff/
> 
> 
> Testing
> -------
> 
> Game was run for 5 rounds in player vs. player mode and then switched to player vs. computer mode, which was then played for 5 rounds. 
> 
> 
> Thanks,
> 
> Stephen Michalski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140919/de0b5ab6/attachment.html>