[Kde-games-devel] Review Request 120193: KF5'ify the library names to make them co-installable with their KDE4 versions.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120193/#review66880
-----------------------------------------------------------

Ship it!


Please lower ECM requirement a bit if we don't need it.

Also i think we don't need ECMPoQmTools, so remove it if possible.

- Albert Astals Cid


On set. 15, 2014, 11:26 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120193/
> -----------------------------------------------------------
> 
> (Updated set. 15, 2014, 11:26 a.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid, Anuj Pahuja, and David Edmundson.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Change the names of the libraries (KF5'ify them) so that they can be co-installed with their KDE4 versions. I assume we can expect that some games will be ported faster than others, so an user might need both libraries installed. With the current setup this is not possible as that they kept the same version and name.
> 
> 
> Diffs
> -----
> 
>   KDEGamesConfig.cmake.in a875ca0 
>   audio/CMakeLists.txt 7fd582f 
>   CMakeLists.txt 1780889 
>   includes/CMakeLists.txt 378ae37 
>   libkdegamesprivate/CMakeLists.txt abd5df8 
>   libkdegamesprivate/tests/CMakeLists.txt 27ffbf9 
>   tests/CMakeLists.txt f5bf4b5 
>   declarativeimports/CMakeLists.txt c512ce9 
>   highscore/CMakeLists.txt c28dff9 
> 
> Diff: https://git.reviewboard.kde.org/r/120193/diff/
> 
> 
> Testing
> -------
> 
> Build libkdegames for KF5 and also build bovo as application against the new libs. Both succeeded 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140918/e5838d21/attachment.html>