[Kde-games-devel] Review Request 120193: KF5'ify the library names to make them co-installable with their KDE4 versions.

[Raymond Wooninck]

> On Sept. 14, 2014, 4:42 p.m., Marko Käning wrote:
> > Hi guys,
> > 
> > this is what I see on the OSX/CI using this patch:
> > ```
> > Linking CXX executable kgamepropertytest.app/Contents/MacOS/kgamepropertytest
> > ld: library not found for -lkdegamesprivate
> > clang: error: linker command failed with exit code 1 (use -v to see invocation)
> > make[2]: *** [libkdegamesprivate/tests/kgamepropertytest.app/Contents/MacOS/kgamepropertytest] Error 1
> > make[1]: *** [libkdegamesprivate/tests/CMakeFiles/kgamepropertytest.dir/all] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > Generating moc_kmessageserver.cpp
> > Generating kplayer.moc
> > /Users/marko/WC/KDECI-builds/libkdegames/libkdegamesprivate/kgame/kplayer.cpp:0: Note: No relevant classes found. No output generated.
> > Generating moc_kgamerenderer.cpp
> > Generating moc_kgamerenderer_p.cpp
> > Generating kgdeclarativeview.moc
> > /Users/marko/WC/KDECI-builds/libkdegames/kgdeclarativeview.cpp:0: Note: No relevant classes found. No output generated.
> > Generating kgamecanvas.moc
> > /Users/marko/WC/KDECI-builds/libkdegames/libkdegamesprivate/kgamecanvas.cpp:0: Note: No relevant classes found. No output generated.
> > Linking CXX executable kgamesvgdocumenttest.app/Contents/MacOS/kgamesvgdocumenttest
> > ld: library not found for -lkdegamesprivate
> > clang: error: linker command failed with exit code 1 (use -v to see invocation)
> > make[2]: *** [libkdegamesprivate/tests/kgamesvgdocumenttest.app/Contents/MacOS/kgamesvgdocumenttest] Error 1
> > make[1]: *** [libkdegamesprivate/tests/CMakeFiles/kgamesvgdocumenttest.dir/all] Error 2
> > Generating kgdifficulty.moc
> > ```
> > 
> > Greets, Marko
> 
> Raymond Wooninck wrote:
>     Found the cause of this failure and have adjusted it in the new version
> 
> Marko Käning wrote:
>     Hi Raymond, this is what I get now:
>     ```
>     [ 31%] [ 32%] Building CXX object CMakeFiles/KF5KDEGames.dir/kgamerendereditem.cpp.o
>     Building CXX object CMakeFiles/KF5KDEGames.dir/kgamerenderedobjectitem.cpp.o
>     /Users/marko/WC/KDECI-builds/libkdegames/highscore/khighscore.cpp:166:9: error: incomplete type 'KSharedConfig' named in nested name specifier
>             KSharedConfig::openConfig()->sync();
>             ^~~~~~~~~~~~~~~
>     /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kconfig/inst/include/KF5/KConfigCore/kconfig.h:370:18: note: forward declaration of 'KSharedConfig'
>         friend class KSharedConfig;
>                      ^
>     /Users/marko/WC/KDECI-builds/libkdegames/highscore/khighscore.cpp:184:70: error: incomplete type 'KSharedConfig' named in nested name specifier
>         return (d->global ? lockedConfig->config : static_cast<KConfig*>(KSharedConfig::openConfig().data()));
>                                                                          ^~~~~~~~~~~~~~~
>     /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kconfig/inst/include/KF5/KConfigCore/kconfig.h:370:18: note: forward declaration of 'KSharedConfig'
>         friend class KSharedConfig;
>                      ^
>     2 errors generated.
>     make[2]: *** [CMakeFiles/KF5KDEGames.dir/highscore/khighscore.cpp.o] Error 1
>     make[2]: *** Waiting for unfinished jobs....
>     make[1]: *** [CMakeFiles/KF5KDEGames.dir/all] Error 2
>     make: *** [all] Error 2
>     ```
>     Greets,
>     Marko

As we shortly discussed, this is not caused by the patch.  At this moment libkdegames (framework branch) has exactly the same error with or without my patch. The issue seems therefore somewhere else and seems to be osx specific.


- Raymond


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120193/#review66483
-----------------------------------------------------------


On Sept. 15, 2014, 11:26 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120193/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 11:26 a.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid, Anuj Pahuja, and David Edmundson.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Change the names of the libraries (KF5'ify them) so that they can be co-installed with their KDE4 versions. I assume we can expect that some games will be ported faster than others, so an user might need both libraries installed. With the current setup this is not possible as that they kept the same version and name.
> 
> 
> Diffs
> -----
> 
>   KDEGamesConfig.cmake.in a875ca0 
>   audio/CMakeLists.txt 7fd582f 
>   CMakeLists.txt 1780889 
>   includes/CMakeLists.txt 378ae37 
>   libkdegamesprivate/CMakeLists.txt abd5df8 
>   libkdegamesprivate/tests/CMakeLists.txt 27ffbf9 
>   tests/CMakeLists.txt f5bf4b5 
>   declarativeimports/CMakeLists.txt c512ce9 
>   highscore/CMakeLists.txt c28dff9 
> 
> Diff: https://git.reviewboard.kde.org/r/120193/diff/
> 
> 
> Testing
> -------
> 
> Build libkdegames for KF5 and also build bovo as application against the new libs. Both succeeded 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140915/72deff1a/attachment-0001.html>