[Kde-games-devel] Review Request 120172: Fix bug #320286 "Two clicks to start a game"

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120172/#review66399
-----------------------------------------------------------

Ship it!


Agreed with you, after having a look at the code i can't see why that would make sense.

- Albert Astals Cid


On set. 12, 2014, 7:31 p.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120172/
> -----------------------------------------------------------
> 
> (Updated set. 12, 2014, 7:31 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 320286
>     http://bugs.kde.org/show_bug.cgi?id=320286
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> KBlocksWin always explcitely ignores the first call to startGame(). As I can not find any reason for that, remove it. Probably some artifact from development work that was forgotten to remove.
> 
> 
> Diffs
> -----
> 
>   KBlocksWin.h 6397988 
>   KBlocksWin.cpp 4156ef0 
> 
> Diff: https://git.reviewboard.kde.org/r/120172/diff/
> 
> 
> Testing
> -------
> 
> * compiles fine
> * running program works fine
> * could not reproduce bug any more
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140913/11de3652/attachment-0001.html>