[Kde-games-devel] Review Request 120076: Fix some warnings in Kigo

[Martin Walch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120076/
-----------------------------------------------------------

(Updated Sept. 8, 2014, 9:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Repository: kigo


Description
-------

These are two commits, but for reviewboard, I merged them into one:

* Fix doxygen warnings for Stone constructors in games/stone.h

"float value" parameters of Stone constructors had no description

Fix it by adding a corresponding description: it is an estimated value
for a potential next move. It is used when the user is requesting
a hint.

* Make single parameter constructors explicit

krazy2 complained:
> Check for C++ ctors that should be declared 'explicit' [explicit]...
> OOPS! 2 issues found!
>
> src/game/score.h: line# 45 (1)
> src/gui/config/generalconfig.h: line# 45 (1)

Fix it by making them explicit.

This is a minor change in a public API (GeneralConfig) and I guess it
could potentially break code that uses those constructors implicitely,
but Kigo compiles fine and even if there is some other program using
that class (I highly doubt it), I am pretty confident that it will not
break unless it actually is a bug.


Diffs
-----

  src/game/score.h ebb2530 
  src/game/stone.h ca199bc 
  src/gui/config/generalconfig.h 2c62428 

Diff: https://git.reviewboard.kde.org/r/120076/diff/


Testing
-------

* compiling
* running the game
* checking doxygen output for param "value" in Stone class


Thanks,

Martin Walch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140908/70a825af/attachment.html>