[Kde-games-devel] Review Request 121117: Don't set a QAction's shortcut directly but through KActionCollection instead.

[Roney Gomes]

> On Nov. 18, 2014, 2:38 p.m., Albert Astals Cid wrote:
> > kstandardgameaction.cpp, line 131
> > <https://git.reviewboard.kde.org/r/121117/diff/2/?file=329103#file329103line131>
> >
> >     Missing braces ?

(*sigh*) Yes. Fixed now.


- Roney


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121117/#review70587
-----------------------------------------------------------


On Nov. 18, 2014, 2:53 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121117/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 2:53 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> I was working on KBounce when I got these alarming messages saying that one should no longer set an action's shortcut directly but to use KActionCollection::setDefaultShortcut(s) instead.
> 
> Usually I don't like to send such a small diff to be reviewed, but as that's the first time I touch libkdegames' code I decided to be careful.
> 
> 
> Diffs
> -----
> 
>   kstandardgameaction.cpp 73d5ac0 
> 
> Diff: https://git.reviewboard.kde.org/r/121117/diff/
> 
> 
> Testing
> -------
> 
> Started the game again to check whether the warnings had desappeared.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141118/1df5cfaa/attachment.html>