[Kde-games-devel] Review Request 120937: Minor cmake cleanup

[šumski]

On Friday 14 of November 2014 20:00:34 tsdgeos at yahoo.es wrote:
> ‎It broke the bovo build. I think kconfigcore somewhere needs to be kconfig
> only. 
Yeah, my mistake .. used the wrong name in cmake.in. Fixed now, and at least 
locally, bovo builds. Sorry for not checking this before push...


Cheers,
Hrvoje
> Can you please make sure you can build bovo after the changes? 
> 
> Cheers, 
>  Albert
> 
> Enviat des del meu telèfon intel·ligent BlackBerry 10.
> De: Hrvoje Senjan
> Enviat: viernes, 14 de noviembre de 2014 19:38
> Per a: Hrvoje Senjan; Commit Hook; Ian Wadham; Albert Astals Cid; KDE Games
> Respon a: Hrvoje Senjan
> Tema: Re: [Kde-games-devel] Review Request 120937: Minor cmake cleanup
> 
>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120937/
> 
> 
> This change has been marked as submitted.
> 
> 
> Review request for KDE Games.
> By Hrvoje Senjan.
> Updated Nov. 14, 2014, 5:44 p.m.
> Repository:  libkdegames
> Description
> explicitly mark public and private dependancies (i've checked the includes
> in the headers), as depending on cmake version, sometimes all are public,
> other times all are private (iirc with 2.8.12). also added find_dependancy
> calls to public ones
>   Testing
> builds
>   Diffs
> CMakeLists.txt (a6a0eb7)
> KDEGamesConfig.cmake.in (36fdb3a)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141114/c7d26a76/attachment.sig>