[Kde-games-devel] Review Request 120937: Minor cmake cleanup

Hrvoje Senjan hrvoje.senjan at gmail.com
Fri Nov 14 17:44:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120937/
-----------------------------------------------------------

(Updated Nov. 14, 2014, 5:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Repository: libkdegames


Description
-------

explicitly mark public and private dependancies (i've checked the includes in the headers), as depending on cmake version, sometimes all are public, other times all are private (iirc with 2.8.12).
also added find_dependancy calls to public ones


Diffs
-----

  CMakeLists.txt a6a0eb7 
  KDEGamesConfig.cmake.in 36fdb3a 

Diff: https://git.reviewboard.kde.org/r/120937/diff/


Testing
-------

builds


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141114/81b9a9b4/attachment.html>


More information about the kde-games-devel mailing list