[Kde-games-devel] Review Request 121117: Don't set a QAction's shortcut directly but through KActionCollection instead.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121117/#review70371
-----------------------------------------------------------



kstandardgameaction.cpp
<https://git.reviewboard.kde.org/r/121117/#comment49202>

    If you're moving cut, you may as well move it inside the if, where it's only used, no?
    
    Have you checked the code of kstandardaction.cpp? This is mostly a copy so we should be doing the same thing it does.


- Albert Astals Cid


On nov. 14, 2014, 12:18 a.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121117/
> -----------------------------------------------------------
> 
> (Updated nov. 14, 2014, 12:18 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> I was working on KBounce when I got these alarming messages saying that one should no longer set an action's shortcut directly but to use KActionCollection::setDefaultShortcut(s) instead.
> 
> Usually I don't like to send such a small diff to be reviewed, but as that's the first time I touch libkdegames' code I decided to be careful.
> 
> 
> Diffs
> -----
> 
>   kstandardgameaction.cpp 73d5ac0 
> 
> Diff: https://git.reviewboard.kde.org/r/121117/diff/
> 
> 
> Testing
> -------
> 
> Started the game again to check whether the warnings had desappeared.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141114/043511af/attachment.html>