[Kde-games-devel] Review Request 120937: Minor cmake cleanup

[Albert Astals Cid]

> On nov. 1, 2014, 10 p.m., Ian Wadham wrote:
> > CMakeLists.txt, line 171
> > <https://git.reviewboard.kde.org/r/120937/diff/1/?file=324438#file324438line171>
> >
> >     The kdegamesprivate library can probably be dropped from KF5.
> >     
> >     IIRC it contains obsolete classes which have been replaced by newer classes in the main KDE Games library OR classes that are not used by any game.
> >     
> >     Individual games which still need to use an obsolete class are supposed to clone it into their code. I do not know if there are any games still dependent on kdegamesprivate, but there should be none by now. The obsolete classes were pushed into kdegamesprivate a couple of years ago.
> 
> Hrvoje Senjan wrote:
>     kmahjongg does link against libKF5KDEGamesPrivate - whether justifiably, i did not check
> 
> Ian Wadham wrote:
>     OK, I will have a look at kmahjongg and see what needs to be done.

There's a few more users of kdegamesprivate besides kmahjongg, not sure how many are real or just copy&paste, but I don't think we're in a point we can drop it.

http://lxr.kde.org/search?v=stable-qt4&_filestring=&_string=USE_UNSTABLE_LIBKDEGAMESPRIVATE_API


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120937/#review69658
-----------------------------------------------------------


On nov. 1, 2014, 7:19 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120937/
> -----------------------------------------------------------
> 
> (Updated nov. 1, 2014, 7:19 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> explicitly mark public and private dependancies (i've checked the includes in the headers), as depending on cmake version, sometimes all are public, other times all are private (iirc with 2.8.12).
> also added find_dependancy calls to public ones
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a6a0eb7 
>   KDEGamesConfig.cmake.in 36fdb3a 
> 
> Diff: https://git.reviewboard.kde.org/r/120937/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141102/7029f38b/attachment.html>