[Kde-games-devel] Review Request 120937: Minor cmake cleanup

[Ian Wadham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120937/#review69658
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/120937/#comment48807>

    The kdegamesprivate library can probably be dropped from KF5.
    
    IIRC it contains obsolete classes which have been replaced by newer classes in the main KDE Games library OR classes that are not used by any game.
    
    Individual games which still need to use an obsolete class are supposed to clone it into their code. I do not know if there are any games still dependent on kdegamesprivate, but there should be none by now. The obsolete classes were pushed into kdegamesprivate a couple of years ago.


- Ian Wadham


On Nov. 1, 2014, 7:19 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120937/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 7:19 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> explicitly mark public and private dependancies (i've checked the includes in the headers), as depending on cmake version, sometimes all are public, other times all are private (iirc with 2.8.12).
> also added find_dependancy calls to public ones
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a6a0eb7 
>   KDEGamesConfig.cmake.in 36fdb3a 
> 
> Diff: https://git.reviewboard.kde.org/r/120937/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141101/ea26df66/attachment.html>