[Kde-games-devel] Review Request 117982: Install LSkat into the correct location on Apple OS X

Ian Wadham iandw.au at gmail.com
Wed May 7 23:37:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117982/
-----------------------------------------------------------

(Updated May 7, 2014, 11:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Repository: lskat


Description
-------

LSkat's CMakeLists.txt requests that the target should be installed into a BIN location, which is the wrong location on Apple Mac OS X and makes the game invisible to end-users, even when it is installed. I am proposing changing the location to ${INSTALL_TARGETS_DEFAULT_ARGS}, which is where all other KDE Games seem to install, certainly all the ones I have looked at.


Diffs
-----

  src/CMakeLists.txt 6fbf07b 

Diff: https://git.reviewboard.kde.org/r/117982/diff/


Testing
-------

Checked that it installed in the same /Applications/ sub-directory as other KDE Games.


Thanks,

Ian Wadham

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140507/4ea4fbf8/attachment.html>


More information about the kde-games-devel mailing list