[Kde-games-devel] Review Request 115946: Palapeli 2.0 - Support for solving large puzzles

[Ian Wadham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115946/#review51582
-----------------------------------------------------------


Thank you, Yuri and Stefan, for your contributions. Most of the issues raised have been fixed and pushed now. The fixes appear in both the master and KDE/4.13 branches. There is still some trouble with zooming out too far in piece holders that are created or restored automatically when a puzzle is loaded. This is on my debugging list.

- Ian Wadham


On Feb. 23, 2014, 9:16 p.m., Ian Wadham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115946/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2014, 9:16 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: palapeli
> 
> 
> Description
> -------
> 
> This is NOT a code review.
> 
> Rather it is a review of how the new Palapeli works, from a user's point of view, when you are solving a large puzzle (300 to 10,000 pieces). Any suggestions for improvement of the way features work are very welcome.
> 
> The complete list of new features is at http://techbase.kde.org/Schedules/KDE4/4.13_Feature_Plan#kdegames and most of them have been pushed to origin master, in preparation for the upcoming freezes of KDE 4.13. You are welcome to review the code on origin master if you wish.
> 
> I would appreciate it if people could build the code and just try it out on a large, but not too difficult puzzle, say 300 to 500 pieces.
> 
> To support solving large puzzles there are some items in the new Move and View menus and some new settings in both Settings dialog pages.
> 
> Notably, there are two new mouse-button operations: "Teleport pieces to or from a holder" (default Shift Left-Click) and "Switch to close-up or distant view" (default Middle-Click). The first works by selecting a holder (click on it, if it does not already have a blue frame), then Shift Left-Click on pieces to teleport them from the puzzle table to the holder. You can also select multiple pieces (e.g. edges) and transfer them all together. To teleport pieces back from a holder, select them inside the holder, then Shift Left-Click an empty spot on the puzzle table. You can also teleport pieces from one holder to another (select in the source, Shift Left-Click in the destination). Teleported pieces are still selected when they arrive, so it is easy to reverse the operation (e.g. if you pick the wrong holder).
> 
> The close-up/distant zoom operation is now a mouse button (not a keystroke), so that you can point to the exact spot in which you are interested. To search the puzzle-table systematically for pieces to sort into holders, I recommend zooming to close-up on a corner of the table, then clicking on the empty spaces in the scroll bars to step through the puzzle table a "page" at a time.
> 
> 
> Diffs
> -----
> 
>   src/engine/triggermapper.cpp 1aa4801 
> 
> Diff: https://git.reviewboard.kde.org/r/115946/diff/
> 
> 
> Testing
> -------
> 
> Lots of testing, with puzzles ranging from 8 to 10,000 pieces, but mainly with the same picture at 24 and 510 pieces.
> 
> There is still some tuning and fixing to be done. Mainly sizing, positioning and scaling piece holders nicely when they are created and used; also enabling/disabling of actions as you switch between the collection and puzzle views.
> 
> 
> Thanks,
> 
> Ian Wadham
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140302/1c904ac1/attachment-0001.html>