[Kde-games-devel] Review Request 114845: [knavalbattle] utilties for the several ships patch

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114845/
-----------------------------------------------------------

(Updated Jan. 15, 2014, 6:49 p.m.)


Review request for KDE Games and Roney Gomes.


Changes
-------

Addressed Roney comments.
Now it is also in the remote branch multipleShips, commit 2ac9da2b00fa15ed0050e05d46b1fe1af9a6c024


Repository: knavalbattle


Description
-------

These are the tools I use to check if a ship can be placed in the board or if the user/AI should start again.
Also, it serves me to split a big patch into smaller pieces.
How it is done:
* Pass the parameter allow adjacent ships also to the BattleField.
* Implement a bool canAddShipOfSize(size). When a ship of size size can not be placed, then the AI or the player should start again (what I'm working on) or an Undo.
* Implement a clear() to be able to start again
* In the battleField also add another hidden board with the cells having only two status (free, busy) to be able to know the availability of the cells. It is easier for me in this way than the other way (sending a signal to clear the ship borders when the shooting starts).


Diffs (updated)
-----

  src/battlefield.h b2f30bc 
  src/battlefield.cpp 6467d8c 
  src/sea.h 4af50b7 
  src/sea.cpp 38ab8b5 

Diff: https://git.reviewboard.kde.org/r/114845/diff/


Testing
-------

It detects the blocked boards (played much more games than I wanted to implement the restart placing ships).


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140115/6625b2c3/attachment.html>