[Kde-games-devel] Review Request 114851: Center board vertically if required.

[Ian Wadham]

> On Jan. 12, 2014, 7:49 p.m., Ian Wadham wrote:
> > Ship It!

Yes, why not? If an issue is undecided and the vote is split, you can invoke KDE's "coder decides" rule ... :-)


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114851/#review47267
-----------------------------------------------------------


On Jan. 5, 2014, 3:36 p.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114851/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 3:36 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The board is centered horizontally already in case the board is tall. If
> it is wide however, it still is aligned to the top leaving empty space
> just at the bottom. This patch vertically centers a wide board.
> 
> 
> Diffs
> -----
> 
>   map/mapitems.cc 2216dda 
>   map/mapscene.h 79666be 
>   map/mapscene.cc ba53c23 
> 
> Diff: https://git.reviewboard.kde.org/r/114851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140112/09942706/attachment.html>