[Kde-games-devel] Review Request 114851: Center board vertically if required.

[Alexander Schuch]

> On Jan. 4, 2014, 6:52 p.m., Albert Astals Cid wrote:
> > Do you think it does look better vertically center aligned than aligned at the top? I'm not much of a konquest player myself so don't really have an opinion. Anyone else?
> 
> Ian Wadham wrote:
>     I'm not a konquest player either, but I think it looks better centered vertically. Also, other games center in both directions, e.g. KPat startup and KGoldrunner.

So I guess I can commit?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114851/#review46816
-----------------------------------------------------------


On Jan. 5, 2014, 3:36 p.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114851/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 3:36 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The board is centered horizontally already in case the board is tall. If
> it is wide however, it still is aligned to the top leaving empty space
> just at the bottom. This patch vertically centers a wide board.
> 
> 
> Diffs
> -----
> 
>   map/mapitems.cc 2216dda 
>   map/mapscene.h 79666be 
>   map/mapscene.cc ba53c23 
> 
> Diff: https://git.reviewboard.kde.org/r/114851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140112/27260df7/attachment.html>