[Kde-games-devel] Review Request 114840: Play a fade-in animation to show the adversary's ships after a defeat.

[Albert Astals Cid]

> On Jan. 3, 2014, 9:02 p.m., Jaime Torres Amate wrote:
> > src/controller.cpp, line 223
> > <https://git.reviewboard.kde.org/r/114840/diff/1/?file=229766#file229766line223>
> >
> >     I did not miss that one. (the other one, yes, I missed it somehow).
> >     
> >     I changed it to emit the gameOver to show the ships just after the game is over, not just after you press the messagebox saying "have better luck next time". But this is just a matter of taste. (Es cuestión de gustos)
> 
> Roney Gomes wrote:
>     Yes, it's certainly about taste.
>     
>     In this case I'll keep this request open until someone else give us a third opinion.
> 
> Albert Astals Cid wrote:
>     So what's the decision?
>     
>     Show enemy's ships before showing the "You lost" messagebox or after pressing "ok" in the "You lost" messagebox?
>     
>     If so, my vote goes for 'before showing the "You lost" messagebox'
> 
> Roney Gomes wrote:
>     Alright then.
>     
>     I'll update master in the next ours (not on my linux box right now) with the ships appearing before the message box, as you preferred.

Note that since i'm not a super kbatlleship player my opinion should not be the one that decides, you guys should decide by yourselves, I was only giving my 0.02 worth opinion.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114840/#review46728
-----------------------------------------------------------


On Jan. 3, 2014, 8:30 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114840/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 8:30 p.m.)
> 
> 
> Review request for KDE Games and Jaime Torres Amate.
> 
> 
> Repository: knavalbattle
> 
> 
> Description
> -------
> 
> Enemy ships now appear in both single player and network mode, that's cool. However, when I first started to work on this feature the ships appeared smoothly on the table after the player pressed the "OK" button of the ending KMessageBox.
> 
> As Jaime didn't work directly on the branch I set up he may have missed these two lines of code.
> 
> 
> Diffs
> -----
> 
>   src/battlefieldview.cpp b682757 
>   src/controller.cpp df44ff4 
> 
> Diff: https://git.reviewboard.kde.org/r/114840/diff/
> 
> 
> Testing
> -------
> 
> I've lost the game a few times in order to see the enemy ships appearing.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140105/8723ca41/attachment-0001.html>