[Kde-games-devel] Review Request 113899: Enable multiple ships game the style I played in paper

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113899/
-----------------------------------------------------------

(Updated Feb. 6, 2014, 7:25 p.m.)


Status
------

This change has been discarded.


Review request for KDE Games and Roney Gomes.


Bugs: 181114 and 308214
    http://bugs.kde.org/show_bug.cgi?id=181114
    http://bugs.kde.org/show_bug.cgi?id=308214


Repository: knavalbattle


Description
-------

The biggest change is the ship insertion order for the human players. It starts now by the biggest ship. This way it is impossible to reach a board where is not possible to place the remaining ships (it is possible starting with the smallest ones if there must be an space between them).
If this change is too big, then I'll try to find a solution to detect the "impossible to place more ships" situation and enable a fresh placing restart.
A kWarning() and a TODO in spanish are now gone.


Diffs
-----

  src/ai/ai.h 738c465 
  src/ai/dummyai.cpp 15544e2 
  src/ai/smartai.h fcf7dba 
  src/ai/smartai.cpp 261cf01 
  src/controller.h e87ba48 
  src/controller.cpp 23b8153 
  src/knavalbattle.kcfg 4d78556 
  src/knavalbattleui.rc bd38ad8 
  src/mainwindow.cpp e3f2a35 
  src/networkentity.cpp 9f252ca 
  src/playerentity.h aae134e 
  src/playerentity.cpp 9c32b25 
  src/playfield.h 6a24657 
  src/playfield.cpp f1d774b 
  src/sea.h e9e7333 
  src/sea.cpp 51f4f0c 

Diff: https://git.reviewboard.kde.org/r/113899/diff/


Testing
-------

A lot of games with and without several ships, in local against the AI or in remote against myself.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140206/916dc0e8/attachment.html>