[Kde-games-devel] Review Request 114735: Update fleet overview dialogue.

Commit Hook null at kde.org
Sun Feb 2 00:54:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114735/#review48755
-----------------------------------------------------------


This review has been submitted with commit 8e48e525ebbe8c805fc7967ce05c9f8147f751db by Alexander Schuch to branch master.

- Commit Hook


On Dec. 30, 2013, 12:23 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114735/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 12:23 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The fleet overview dialogue is not resized to a constant size anymore, and
> automatically adopts to the number of (own) attack fleets. Numbers shown in
> that dialogue are handled as numbers now rather than as strings so that
> they are sorted properly (1, 2, 10, 20 instead of 1, 10, 2, 20). They are
> as well aligned to the right so that they are nicer to read. The source and
> destination planet fields show the player colour of the owner now.
> 
> The structure resembles the one of the standings widget and this indeed
> is a first step of converting the dialogue into a dockable widget.
> 
> 
> Diffs
> -----
> 
>   dialogs/fleetdlg.h 25ef36d 
>   dialogs/fleetdlg.cc 944eefe 
>   view/standingswidget.cpp 04bd8d0 
> 
> Diff: https://git.reviewboard.kde.org/r/114735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140202/48b4cae8/attachment.html>


More information about the kde-games-devel mailing list