[Kde-games-devel] Review Request 121653: Break out parts of updateSpriteMap to reduce code duplication

Jan-Peter Nilsson peppe at pappkartong.se
Tue Dec 23 20:28:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121653/
-----------------------------------------------------------

Review request for KDE Games.


Repository: kmahjongg


Description
-------

This patch breaks out parts of updateSpriteMap to private methods in order to reduce code duplication between the different viewing angles.


Diffs
-----

  boardwidget.h f1e0483 
  boardwidget.cpp 04ba8c5 

Diff: https://git.reviewboard.kde.org/r/121653/diff/


Testing
-------

I have verified that the center tile of the default layout remain at the same position as with the original code for all four angles.


Thanks,

Jan-Peter Nilsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141223/7b92f949/attachment.html>


More information about the kde-games-devel mailing list