[Kde-games-devel] Review Request 120192: FIx for issue 337826 where the status bar would not update to reflect the player name until a game was initiated. Also changed the default name for the left player to "KSnakeDuel".

[Stephen Michalski]

On 12/19/2014 07:04 PM, Albert Astals Cid wrote:
> El Dimarts, 16 de desembre de 2014, a les 19:55:53, Stephen Michalski va
> escriure:
>> For some reason I'm running to build issues that I wasn't running into
>> before. I've had to reformat the machine the original code was on and
>> ended up having to reconfigure Qt4.
> Why not using Qt4 from your distro?
That still requires configuration for some reason. I couldn't get the 
project to build without defining the DQT_QMAKE_EXECUTABLE variable. 
Though I did figure out I could use Tools > Options... > Build & Run > 
Kits to create an environment for ksnakeduel.
>> I can try to reproduce the issue
>> you're experiencing once I figure out why the themes are copying to the
>> project output directory.
> Not sure i understand what your problem is really. What is copied where?
>
> Cheers,
>    Albert
I apologize. What I meant to say is that I can't figure out why the 
themes *are not* being copied to the output directory. I have tried 
manually copying the theme files to the output directory, but that still 
results in an unusable program since nothing is actually drawn inside 
the window.
>> Would there be any ideas as to why this would be? I've cloned the
>> location from git clone git://anongit.kde.org/ksnakeduel and the only
>> configuration I had to make was pointing cmake to my qmake-qt4 binary.
>>
>> On 12/14/2014 01:43 PM, Albert Astals Cid wrote:
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://git.reviewboard.kde.org/r/120192/
>>>
>>>
>>> This still seems to not totally work for me.
>>>
>>>
>>> This is what i did: rm ~/.kde/share/config/ktronrc (or .kde4 if your
>>> settings are there) start ktron
>>>
>>>
>>> And the welcome screen says "KSnakeDuel (0 points) versus (0 points)"
>>> (i.e. the name seems to be empty)
>>>
>>>
>>> And if i go to settings -> Configure, Right Player is empty and left
>>> is "Player 2".
>>>
>>>
>>> Can you reproduce this?
>>>
>>>
>>> - Albert Astals Cid
>>>
>>>
>>> On octubre 14th, 2014, 3:13 p.m. UTC, Stephen Michalski wrote:
>>>
>>> Review request for KDE Games and Albert Astals Cid.
>>> By Stephen Michalski.
>>>
>>> /Updated oct. 14, 2014, 3:13 p.m./
>>>
>>> *Bugs: * 337826 <http://bugs.kde.org/show_bug.cgi?id=337826>
>>> *Repository: * ksnakeduel
>>>
>>>    Description
>>>
>>> Fix for bug 337826
>>>
>>>    Testing
>>>
>>> Game was run for 5 rounds in player vs. player mode and then switched
>>> to player vs. computer mode, which was then played for 5 rounds.
>>>
>>>    Diffs
>>>    
>>>    * ktron.cpp (4082ff6)
>>>    * ktron.kcfg (ab764b9)
>>>
>>> View Diff <https://git.reviewboard.kde.org/r/120192/diff/>