[Kde-games-devel] Review Request 120192: FIx for issue 337826 where the status bar would not update to reflect the player name until a game was initiated. Also changed the default name for the left player to "KSnakeDuel".

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120192/#review71996
-----------------------------------------------------------


This still seems to not totally work for me.

This is what i did:
  rm ~/.kde/share/config/ktronrc  (or .kde4 if your settings are there)
  start ktron
  
And the welcome screen says "KSnakeDuel (0 points) versus (0 points)" (i.e. the name seems to be empty)

And if i go to settings -> Configure, Right Player is empty and left is "Player 2".

Can you reproduce this?

- Albert Astals Cid


On oct. 14, 2014, 3:13 p.m., Stephen Michalski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120192/
> -----------------------------------------------------------
> 
> (Updated oct. 14, 2014, 3:13 p.m.)
> 
> 
> Review request for KDE Games and Albert Astals Cid.
> 
> 
> Bugs: 337826
>     http://bugs.kde.org/show_bug.cgi?id=337826
> 
> 
> Repository: ksnakeduel
> 
> 
> Description
> -------
> 
> Fix for bug 337826
> 
> 
> Diffs
> -----
> 
>   ktron.cpp 4082ff6 
>   ktron.kcfg ab764b9 
> 
> Diff: https://git.reviewboard.kde.org/r/120192/diff/
> 
> 
> Testing
> -------
> 
> Game was run for 5 rounds in player vs. player mode and then switched to player vs. computer mode, which was then played for 5 rounds. 
> 
> 
> Thanks,
> 
> Stephen Michalski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141214/8be62729/attachment-0001.html>