[Kde-games-devel] Review Request 120008: This patch ports bovo to KF5

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120008/#review65590
-----------------------------------------------------------



gui/main.cc
<https://git.reviewboard.kde.org/r/120008/#comment45842>

    Isn't this what setApplicationData does?



gui/main.cc
<https://git.reviewboard.kde.org/r/120008/#comment45841>

    The application domain is bovo, not libkdegames. And this needs to go before any use of i18n, otherwise you're too late.


- Albert Astals Cid


On ago. 30, 2014, 8:03 p.m., Sandro Andrade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120008/
> -----------------------------------------------------------
> 
> (Updated ago. 30, 2014, 8:03 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: bovo
> 
> 
> Description
> -------
> 
> This patch ports bovo to KF5. It seems the unit test in game/test doesn't build with KDE 4, so it hasn't been ported.
> 
> 
> Diffs
> -----
> 
>   icons/hi32-apps-bovo.png PRE-CREATION 
>   icons/hi48-app-bovo.png 170a4e0e0daed5fa6f48c45483f1305308745ca3 
>   icons/CMakeLists.txt 02e3c9e 
>   icons/hi128-app-bovo.png 9f8bec382d8a8c4678192e2c05d192e90386f215 
>   icons/hi128-apps-bovo.png PRE-CREATION 
>   icons/hi16-app-bovo.png 6a16a316cca0fbd35dcb622a93b19168704a8c08 
>   icons/hi16-apps-bovo.png PRE-CREATION 
>   icons/hi22-app-bovo.png 4fbc1e1eb6dc274c03b9fe98525d9e6f7d94424d 
>   icons/hi22-apps-bovo.png PRE-CREATION 
>   icons/hi32-app-bovo.png 708c4ec34b95eb82639ee2f0ff543607fec363bb 
>   CMakeLists.txt f8087ef 
>   doc/CMakeLists.txt 166cada 
>   gui/main.cc b0f89da 
>   gui/mainwindow.h e0502c6 
>   gui/mainwindow.cc 3fb973f 
>   icons/hi48-apps-bovo.png PRE-CREATION 
>   icons/hi64-app-bovo.png 04d261c727ad0a97696c9068a0eebaf4a11b6de8 
>   icons/hi64-apps-bovo.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120008/diff/
> 
> 
> Testing
> -------
> 
> - cmake finds all required KDE 5 frameworks
> - builds ok, with some warning messages
> - bovo themes and icons are correctle installed
> - game functionalities seems work properly
> 
> 
> Thanks,
> 
> Sandro Andrade
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140831/03eb7afa/attachment.html>