[Kde-games-devel] May I fix warning messages from the Clang compiler?

[Ian Wadham]

On 01/04/2014, at 6:50 PM, Albert Astals Cid wrote:

> El Dimarts, 1 d'abril de 2014, a les 07:30:56, Inge Wallin va escriure:
>> On Tuesday, April 01, 2014 13:53:56 Ian Wadham wrote:
>>> I am getting peppered with unwanted warning messages from
>>> a new version of the Clang compiler when it is referencing legacy
>>> Palapeli code [1] and this is making it hard for me to see a genuine
>>> error message when there is one.
>>> 
>>> Is it OK to fix these warnings and push them to KDE/4.13 at this
>>> late stage of the release?
>> 
>> If you ask me then trivial fixes like that should be done ASAP. On the other
>> hand we really don't want to introduce any bugs into the code base this
>> late into the release process.
> 
> Fixing this kind of warnings (not sure if you got some other ones) can't 
> really introduce any bugs other than the obvious "you made it not compile 
> anymore".
> 
> So if it's only class vs struct definitions i'd go ahead and fix it in all the 
> branches you care about.

OK.  I'll push just the struct/class fixes to Master and KDE/4.13.  They are
the most frequent causes of warnings.  The others can wait.  Thanks, Albert.

Cheers, Ian W.