[Kde-games-devel] Review Request 110137: PopupItem QML component for KGamePopupItem

[Viranch Mehta]

> On Sept. 25, 2013, 8:23 p.m., Albert Astals Cid wrote:
> > Viranch, what's the status of this? Do you think we can make it work? Or should it be discarded until we can use KStatefulBrush? Or...?
> 
> Denis Kuplyakov wrote:
>     I am working on it now. See this two:
>     https://git.reviewboard.kde.org/r/112880/
>     https://git.reviewboard.kde.org/r/112873/
>     
>     Current PopupItem.qml is included at KReversi's deniskup/gsoc2013/newdesign branch. And we are waiting KColorSchemeToken to be included at kdelibs.

I think this review request can be discarded since it seems obsolete given Denis's work on the same. Once his kdelibs requirements are resolved, we will review the KReversi port (which would include QML component for KGamePopupItem) and merge to master, and then once it seems to work fine (after a release or so), we can move it to libkdegames and port KReversi to it. Sounds good?


- Viranch


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110137/#review40805
-----------------------------------------------------------


On April 23, 2013, 7:51 p.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110137/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 7:51 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Implements a QML component KgCore.PopupItem for KGamePopupItem widget. Most of the properties of KGamePopupItem are provided by PopupItem, except ability to set the background brush (can set background color instead), and ability to set a custom QPixmap as icon (can set KIcon's name instead and switch showing icon on/off instead).
> 
> Although one of the critical downside is it cannot set theme based background and text colors. Not sure how to overcome this. But at least we have the component for starting to use in ports.
> 
> 
> Diffs
> -----
> 
>   declarativeimports/qml/PopupItem.qml PRE-CREATION 
>   declarativeimports/qml/qmldir 79aae32 
> 
> Diff: http://git.reviewboard.kde.org/r/110137/diff/
> 
> 
> Testing
> -------
> 
> The KMines port (viranch/qtquick branch in kmines) uses this component (src/qml/main.qml) for showing "paused" message when game is paused/unpaused. works as expected except themed colors.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130929/dd1fd3d6/attachment.html>