[Kde-games-devel] Review Request 112884: Bugs 272956, 167588, 186483

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112884/#review40822
-----------------------------------------------------------

Ship it!


You're probably the person that knows most about the code at this stage. Honestly I can not see myself reviewing stuff and knowing more than you unless it's very trivial or related to non core stuff. I've had a quick look at the diff between the branches and have found nothing that screamed "YOU'RE DOING IT WRONG" to my face. So I guess you should commit ;-)

- Albert Astals Cid


On Sept. 22, 2013, 3:56 p.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112884/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2013, 3:56 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Unlock all cells at once.
> make cable animation time configurable.
> request an option that pieces are locked after being moved.
> 
> Commits are in 'ashwin' branch of KNetWalk.
> 
> 
> This addresses bugs 167588, 186483 and 272956.
>     http://bugs.kde.org/show_bug.cgi?id=167588
>     http://bugs.kde.org/show_bug.cgi?id=186483
>     http://bugs.kde.org/show_bug.cgi?id=272956
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/112884/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130925/280257d9/attachment.html>