[Kde-games-devel] Review Request 113477: Add action for "end turn".

[Albert Astals Cid]

> On Oct. 28, 2013, 11:26 p.m., Albert Astals Cid wrote:
> > Makes sense to me.
> > 
> > Alexander if you're planning to keep hacking on konquest you should probably get a contributor account[1]. This does not mean you should stop doing this reviews (even though for trivial stuff it may make sense) but it makes easier for us reviewers since we only have to say "ship it" and then it's you doing the commit. Want to get one and try with this one?
> > 
> > [1] http://techbase.kde.org/Contribute/Get_a_Contributor_Account
> 
> Alexander Schuch wrote:
>     I applied for an account. So yes, I like to try it.
> 
> Alexander Schuch wrote:
>     I pushed it now. Did it work well?
> 
> Alexander Schuch wrote:
>     Oh, and what's the deal with "FIXED-IN"? Am I supposed to use that? How do I figure out the value to use? Or better just ignore it?

All fine, FIXED-IN is to set the "Version fixed in" field in https://bugs.kde.org/show_bug.cgi?id=272817
As a KDE developer you are expected to know what is our next version and stuff, but since you're new it's ok not to know much ;-)
master is now (not for much more) http://techbase.kde.org/Schedules/KDE4/4.12_Release_Schedule
while the KDE/4.11 branch is obviously http://techbase.kde.org/Schedules/KDE4/4.11_Release_Schedule
So you should have written something like FIXED-IN: 4.12.0


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113477/#review42565
-----------------------------------------------------------


On Oct. 30, 2013, 12:22 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113477/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 12:22 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 272817
>     http://bugs.kde.org/show_bug.cgi?id=272817
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The action to end a turn now is a "real" action. It is available in the menu bar and as such can get any shortcut assigned by the user. It can also be added to the toolbar.
> 
> 
> Diffs
> -----
> 
>   mainwin.h 81d0ab4 
>   mainwin.cc b9dfdff 
> 
> Diff: http://git.reviewboard.kde.org/r/113477/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131030/14500405/attachment-0001.html>