[Kde-games-devel] Review Request 113477: Add action for "end turn".

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113477/#review42565
-----------------------------------------------------------

Ship it!


Makes sense to me.

Alexander if you're planning to keep hacking on konquest you should probably get a contributor account[1]. This does not mean you should stop doing this reviews (even though for trivial stuff it may make sense) but it makes easier for us reviewers since we only have to say "ship it" and then it's you doing the commit. Want to get one and try with this one?

[1] http://techbase.kde.org/Contribute/Get_a_Contributor_Account

- Albert Astals Cid


On Oct. 28, 2013, 12:05 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113477/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 12:05 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 272817
>     http://bugs.kde.org/show_bug.cgi?id=272817
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The action to end a turn now is a "real" action. It is available in the menu bar and as such can get any shortcut assigned by the user. It can also be added to the toolbar.
> 
> 
> Diffs
> -----
> 
>   mainwin.h 81d0ab4 
>   mainwin.cc b9dfdff 
> 
> Diff: http://git.reviewboard.kde.org/r/113477/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131028/2f05e828/attachment.html>