[Kde-games-devel] Review Request 113446: Improve checking for a sane game configuration.

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113446/
-----------------------------------------------------------

(Updated Oct. 27, 2013, 12:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Bugs: 319808
    http://bugs.kde.org/show_bug.cgi?id=319808


Repository: konquest


Description
-------

The game will never end if none of the players has any planets. This patch makes sure that the game can only be started if all non-spectator players do have at least one planet.

Some internal variables are renamed to make the name match their content/purpose much better.

This fixes issue #319808.

If you want me to split the bugfix from the variable renaming, please just say so. It "just happened" on my quest to find the involved events.


Diffs
-----

  dialogs/newgamedlg.cc ad0d931 

Diff: http://git.reviewboard.kde.org/r/113446/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131027/b534b6cc/attachment.html>