[Kde-games-devel] Review Request 112873: QML port for KReversi

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112873/#review42258
-----------------------------------------------------------


You don't seem to need ${QT_QTXML_LIBRARY}, no?

Also on startup i get
QDeclarativeExpression: Expression "(function $color() { return useCustomBackgroundColor ? backgroundColor : colorScheme.background })" depends on non-NOTIFYable properties: 
    ColorScheme::background
QDeclarativeExpression: Expression "(function $color() { return colorScheme.foreground })" depends on non-NOTIFYable properties: 
    ColorScheme::foreground
QDeclarativeExpression: Expression "(function $color() { return useCustomBorderColor ? borderColor : colorScheme.border })" depends on non-NOTIFYable properties: 
    ColorScheme::border
QDeclarativeExpression: Expression "(function $color() { return useCustomBorderColor ? borderColor : colorScheme.border })" depends on non-NOTIFYable properties: 
    ColorScheme::border
QDeclarativeExpression: Expression "(function $color() { return colorScheme.foreground })" depends on non-NOTIFYable properties: 
    ColorScheme::foreground
QDeclarativeExpression: Expression "(function $color() { return useCustomBackgroundColor ? backgroundColor : colorScheme.background })" depends on non-NOTIFYable properties: 
    ColorScheme::background
i guess it's "ok" but looks scary to Joe Random User, so may as well add the notify signals even if you never send them



>From a look at the code, the only thing i don't like it's all those QMetaObject::invokeMethod 

A more QML-y way to do that would be some objects emmitting some signals and the qml side running the function as answer to those signals, but in essence "it's the same", so I'm not going to argue for you to change it if you don't want.

Now, the thing is, next wednesday is the freeze for 4.12, and we probably want this in, don't want you to do a lot of work for nothing.

Question, is there anyone else that feels like looking at the code? Or shall we just commit it?

Also, I understand you are going to stay around to fix any possible issues that your code shows, right?

- Albert Astals Cid


On Oct. 22, 2013, 5:42 p.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112873/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 5:42 p.m.)
> 
> 
> Review request for KDE Games and Viranch Mehta.
> 
> 
> Repository: kreversi
> 
> 
> Description
> -------
> 
> QML port for KReversi.
> 
> List of changes:
> 1) KReversiChip and KReversiScene classes were deleted as they not needed
> 2) default_theme.desktop files is now installed to make KgThemeProvider discover it
> 3) Added folowing QML files:
>     Table (contains Board and Popup, draws background)
>     Popup (implements KgPopupItem)
>     Board (draws board with labels and grid of Cells)
>     Cell (represents cell of board, contains Chip and displays various marks)
>     Chip (draws chip and it's animation)
>     CanvasItem (wrapper to acces themeProvider allover the code),
>     globals (used to store constants)
> 4) Fixed bug: "If you undo move, last move marker isn't showing"
> 5) KReversiView was compeletely rewritten to use QML implementation.
> 6) Minor changes at other files: added credits to me, deleted QGraphicsScene specific things
> 7) Introduced ColorScheme class to access KColorScheme color from QML.
> 8) Documentation is uptodate now.
> 
> Current bugs: I haven't found any ;)
> 
> Future plans:
> See http://kreversiqml.blogspot.ru/2013/08/new-kreversi-design.html . All of this is implemented at deniskup/gsoc2013/newdesign branch. Now I am working on
> 1) post a patch to kdelibs that will make possible using of ColorScheme class (I mean newdesign implementation here)
> 2) export ColorScheme class to kdelibs as KColorSchemeToken
> * search for "KDE theme colors API for QML" thread at kdelibs mailinglists *
> 3) export Popup.qml to libkdegames
> 4) apply newdesign
> 
> 
> Diffs
> -----
> 
>   AUTHORS 93f0925 
>   CMakeLists.txt 8f650f8 
>   DESIGN d2a1320 
>   TODO 97aedcd 
>   colorscheme.h PRE-CREATION 
>   colorscheme.cpp PRE-CREATION 
>   kreversichip.h 37695b9 
>   kreversichip.cpp f6e909d 
>   kreversigame.h d6b8a43 
>   kreversigame.cpp 4fb231b 
>   kreversiscene.h 6880a67 
>   kreversiscene.cpp 2731f78 
>   kreversiview.h ff3db89 
>   kreversiview.cpp 1c80e4b 
>   main.cpp dd05bd4 
>   mainwindow.h c9c3160 
>   mainwindow.cpp 1855b16 
>   pics/CMakeLists.txt 744ec7b 
>   qml/Board.qml PRE-CREATION 
>   qml/CanvasItem.qml PRE-CREATION 
>   qml/Cell.qml PRE-CREATION 
>   qml/Chip.qml PRE-CREATION 
>   qml/Popup.qml PRE-CREATION 
>   qml/Table.qml PRE-CREATION 
>   qml/globals.js PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112873/diff/
> 
> 
> Testing
> -------
> 
> Have played it many times, it seems to work right.
> 
> 
> File Attachments
> ----------------
> 
> No space diff
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/22/36a61da1-6ed3-4729-8e7a-adcbea5b3026__master_qtquick.diff
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131023/50decd6b/attachment-0001.html>