[Kde-games-devel] Review Request 113113: add local spectator player

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113113/
-----------------------------------------------------------

(Updated Oct. 22, 2013, 2:23 a.m.)


Review request for KDE Games.


Repository: konquest


Description (updated)
-------

For AI development it is useful to watch the AIs play. This patch adds a new local human spectator player controller which does not have any planets and does not count as active player.

In case all selected player controllers are spectators, or only one non-spectating player controller is set, consider the match as spectator-only and reject it as there is either no winner at all, or the winner is known already (the only non-spectating player).


Diffs (updated)
-----

  players/spectatorplayer_gui.cpp PRE-CREATION 
  players/spectatorplayer.cpp PRE-CREATION 
  players/spectatorplayer_gui.h PRE-CREATION 
  players/spectatorplayer.h PRE-CREATION 
  players/player.h a6d91c4 
  players/player.cpp 7135127 
  players/localplayer_gui.cpp 44a04b5 
  players/localplayer.h a12b46f 
  players/localplayer.cpp dbb47f3 
  players/computerplayer.cpp f4fd7a2 
  gameview.cc ebba726 
  players/computerplayer.h 29b6b77 
  CMakeLists.txt b67b4ba 
  dialogs/newgamedlg.h 70e8a1a 
  dialogs/newgamedlg.cc 6f376ed 
  game.cpp 5746b22 

Diff: http://git.reviewboard.kde.org/r/113113/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131022/f73df529/attachment.html>