[Kde-games-devel] Review Request 113113: add local spectator player

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113113/
-----------------------------------------------------------

(Updated Oct. 19, 2013, 11:32 p.m.)


Review request for KDE Games.


Changes
-------

Updated patch to not allow a match with only spectator player controllers to begin.


Repository: konquest


Description
-------

For AI development it is useful to watch the AIs play. This patch adds a new local human spectator player which does not have any planets and does not count as active player.

Known issues: If all players are spectators, the game will never end.


Diffs (updated)
-----

  CMakeLists.txt b67b4ba 
  dialogs/newgamedlg.h 70e8a1a 
  dialogs/newgamedlg.cc 6f376ed 
  game.cpp 5746b22 
  gameview.cc ebba726 
  players/computerplayer.h 29b6b77 
  players/computerplayer.cpp f4fd7a2 
  players/localplayer.h a12b46f 
  players/localplayer.cpp dbb47f3 
  players/localplayer_gui.cpp 44a04b5 
  players/player.h a6d91c4 
  players/player.cpp 7135127 
  players/spectatorplayer.h PRE-CREATION 
  players/spectatorplayer.cpp PRE-CREATION 
  players/spectatorplayer_gui.h PRE-CREATION 
  players/spectatorplayer_gui.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113113/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131019/73b40b57/attachment.html>